[10.0][FIX] action server in tree view must play on all selected records #458

bguillot · 2019-10-08T14:14:20Z

Hi,

The action server in tree view works only on the first selected record.

The PR fixes it.

acsonefho

LGTM

lmignon · 2019-10-09T10:19:35Z

shopinvader_search_engine/views/product_view.xml

-        for template in object:
+        for template in records:


IMO this code should no work... template is never used

Yes thats right, it's luck that my patch fixed the bug ...
I will fix it.

rousseldenis · 2019-11-28T14:50:33Z

@bguillot

rousseldenis · 2020-02-12T16:25:59Z

@bguillot Any news ?

codecov-io · 2020-05-01T14:58:17Z

Codecov Report

Merging #458 into 10.0 will decrease coverage by 1.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             10.0     #458      +/-   ##
==========================================
- Coverage   90.45%   89.38%   -1.07%     
==========================================
  Files         151      136      -15     
  Lines        4054     3542     -512     
==========================================
- Hits         3667     3166     -501     
+ Misses        387      376      -11

Impacted Files	Coverage Δ
...ocomotive_reset_password/wizards/reset_password.py	`47.82% <0.00%> (-48.85%)`	⬇️
...le/components/shopinvader_partner_export_mapper.py	`83.33% <0.00%> (-16.67%)`	⬇️
shopinvader/services/service.py	`76.00% <0.00%> (-9.87%)`	⬇️
...e/component/shopinvader_binging_event_listeners.py	`85.71% <0.00%> (-7.15%)`	⬇️
shopinvader/shopinvader_response.py	`93.33% <0.00%> (-6.67%)`	⬇️
shopinvader/services/cart.py	`87.81% <0.00%> (-3.03%)`	⬇️
shopinvader/controllers/main.py	`37.14% <0.00%> (-2.86%)`	⬇️
shopinvader_invoice/services/invoice.py	`97.50% <0.00%> (-2.50%)`	⬇️
shopinvader/services/abstract_sale.py	`97.56% <0.00%> (-2.44%)`	⬇️
shopinvader/services/address.py	`93.44% <0.00%> (-2.21%)`	⬇️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fb288e...85fe8dc. Read the comment docs.

sebastienbeau · 2020-05-01T14:58:32Z

I have rebased the work and added a test so it's ready for merging

sebastienbeau · 2020-05-04T18:48:48Z

/ocabot merge minor

shopinvader-git-bot · 2020-05-04T18:49:00Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 10.0-ocabot-merge-pr-458-by-sebastienbeau-bump-minor, awaiting test results.

Signed-off-by sebastienbeau

shopinvader-git-bot · 2020-05-04T19:27:30Z

@sebastienbeau The merge process could not start, because command `git merge --no-ff -m Merge PR #458 into 10.0

Signed-off-by sebastienbeau tmp-pr-458` failed with output:

Auto-merging shopinvader_search_engine/tests/__init__.py
CONFLICT (add/add): Merge conflict in shopinvader_search_engine/tests/__init__.py
Automatic merge failed; fix conflicts and then commit the result.

shopinvader-git-bot · 2020-05-04T19:27:31Z

@sebastienbeau The merge process could not be finalized, because command `git merge --no-ff -m Merge PR #458 into 10.0

Signed-off-by sebastienbeau tmp-pr-458` failed with output:

Auto-merging shopinvader_search_engine/tests/__init__.py
CONFLICT (add/add): Merge conflict in shopinvader_search_engine/tests/__init__.py
Automatic merge failed; fix conflicts and then commit the result.

rousseldenis · 2020-05-18T08:29:07Z

@bguillot Could you fix conflict ?

codecov-commenter · 2020-05-19T07:37:37Z

Codecov Report

❗ No coverage uploaded for pull request base (10.0@084d5bd). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             10.0     #458   +/-   ##
=======================================
  Coverage        ?   90.50%           
=======================================
  Files           ?      151           
  Lines           ?     4064           
  Branches        ?        0           
=======================================
  Hits            ?     3678           
  Misses          ?      386           
  Partials        ?        0

Impacted Files	Coverage Δ
...le/components/shopinvader_partner_export_mapper.py	`100.00% <0.00%> (ø)`
shopinvader/services/address.py	`95.65% <0.00%> (ø)`
...nvader_delivery_carrier/models/delivery_carrier.py	`100.00% <0.00%> (ø)`
shopinvader/services/customer.py	`89.47% <0.00%> (ø)`
shopinvader/models/shopinvader_variant.py	`98.24% <0.00%> (ø)`
shopinvader_algolia/components/deleter.py	`100.00% <0.00%> (ø)`
shopinvader_lead/services/lead.py	`96.00% <0.00%> (ø)`
...r/wizards/shopinvader_category_unbinding_wizard.py	`92.30% <0.00%> (ø)`
shopinvader/models/seo_title_mixin.py	`100.00% <0.00%> (ø)`
shopinvader_product_new/models/product_template.py	`100.00% <0.00%> (ø)`
... and 141 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 084d5bd...32157fe. Read the comment docs.

rousseldenis · 2020-05-22T13:21:39Z

@lmignon Could you update your review ?

shopinvader-git-bot · 2020-05-24T09:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

lmignon · 2020-05-25T06:20:41Z

/ocabot merge patch

shopinvader-git-bot · 2020-05-25T06:20:53Z

On my way to merge this fine PR!
Prepared branch 10.0-ocabot-merge-pr-458-by-lmignon-bump-patch, awaiting test results.

shopinvader-git-bot · 2020-05-25T06:56:20Z

Congratulations, your PR was merged at 8076961. Thanks a lot for contributing to shopinvader. ❤️

bguillot mentioned this pull request Oct 8, 2019

[FIX] action server in tree view must play on all selected records #459

Closed

acsonefho approved these changes Oct 9, 2019

View reviewed changes

lmignon requested changes Oct 9, 2019

View reviewed changes

sebastienbeau added the 10.0 label Apr 22, 2020

sebastienbeau changed the title ~~[FIX] action server in tree view must play on all selected records~~ [10.0][FIX] action server in tree view must play on all selected records May 1, 2020

sebastienbeau force-pushed the 10.0-fix-recompute-action-server branch from e45e12c to 85fe8dc Compare May 1, 2020 14:58

sebastienbeau added the needs review label May 1, 2020

shopinvader-git-bot pushed a commit that referenced this pull request May 4, 2020

Merge PR #458 into 10.0

55ca0b2

Signed-off-by sebastienbeau

shopinvader-git-bot added the bot is merging ⏳ label May 4, 2020

lmignon mentioned this pull request May 4, 2020

Forward-port / Back-port TODO #416

Closed

77 tasks

shopinvader-git-bot removed the bot is merging ⏳ label May 4, 2020

bguillot added 2 commits May 19, 2020 09:36

[FIX] action server in tree view must play on all selected records

8c98701

[FIX] action server also for category

be844c5

bguillot force-pushed the 10.0-fix-recompute-action-server branch from 85fe8dc to be844c5 Compare May 19, 2020 07:37

[IMP] add tests for recompute action

32157fe

lmignon approved these changes May 24, 2020

View reviewed changes

shopinvader-git-bot added approved ready to merge labels May 24, 2020

shopinvader-git-bot added the bot is merging ⏳ label May 25, 2020

shopinvader-git-bot merged commit f0fcdb1 into shopinvader:10.0 May 25, 2020

shopinvader-git-bot added merged 🎉 and removed bot is merging ⏳ labels May 25, 2020

sebastienbeau mentioned this pull request Aug 31, 2020

[12.0][PORT] 458 from 10.0 #761

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[10.0][FIX] action server in tree view must play on all selected records #458

[10.0][FIX] action server in tree view must play on all selected records #458

bguillot commented Oct 8, 2019

acsonefho left a comment

lmignon Oct 9, 2019

bguillot Oct 9, 2019

rousseldenis commented Nov 28, 2019

rousseldenis commented Feb 12, 2020

codecov-io commented May 1, 2020

sebastienbeau commented May 1, 2020

sebastienbeau commented May 4, 2020

shopinvader-git-bot commented May 4, 2020

shopinvader-git-bot commented May 4, 2020

shopinvader-git-bot commented May 4, 2020

rousseldenis commented May 18, 2020

codecov-commenter commented May 19, 2020 •

edited

Loading

rousseldenis commented May 22, 2020

shopinvader-git-bot commented May 24, 2020

lmignon commented May 25, 2020

shopinvader-git-bot commented May 25, 2020

shopinvader-git-bot commented May 25, 2020

[10.0][FIX] action server in tree view must play on all selected records #458

[10.0][FIX] action server in tree view must play on all selected records #458

Conversation

bguillot commented Oct 8, 2019

acsonefho left a comment

Choose a reason for hiding this comment

lmignon Oct 9, 2019

Choose a reason for hiding this comment

bguillot Oct 9, 2019

Choose a reason for hiding this comment

rousseldenis commented Nov 28, 2019

rousseldenis commented Feb 12, 2020

codecov-io commented May 1, 2020

Codecov Report

sebastienbeau commented May 1, 2020

sebastienbeau commented May 4, 2020

shopinvader-git-bot commented May 4, 2020

shopinvader-git-bot commented May 4, 2020

shopinvader-git-bot commented May 4, 2020

rousseldenis commented May 18, 2020

codecov-commenter commented May 19, 2020 • edited Loading

Codecov Report

rousseldenis commented May 22, 2020

shopinvader-git-bot commented May 24, 2020

lmignon commented May 25, 2020

shopinvader-git-bot commented May 25, 2020

shopinvader-git-bot commented May 25, 2020

codecov-commenter commented May 19, 2020 •

edited

Loading